nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1561346286
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -137,6 +137,10 @@ public void initialize(String name, Map<String, String>
properties) {
this.connections = new JdbcClientPool(uri, properties);
}
+ String initializeTablesProp = properties.get(PROPERTY_PREFIX +
"initialize-catalog-tables");
Review Comment:
you might want to add this rather to `JdbcUtil` (and rename it to
`init-catalog-tables`). Also please add some tests to `TestJdbcCatalog`, where
the property is set to something different than what is passed to
`initializeCatalogTables` via the constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
