Re: [PR] Core: Add commit timestamp to CommitReport [iceberg]

2025-05-08 Thread via GitHub
manuzhang commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2079333822 ## open-api/rest-catalog-open-api.yaml: ## @@ -3775,6 +3775,9 @@ components: properties: table-name: type: string +timestamp-mill

Re: [PR] Core: Add commit timestamp to CommitReport [iceberg]

2025-05-08 Thread via GitHub
nastra commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2079250755 ## open-api/rest-catalog-open-api.yaml: ## @@ -3775,6 +3775,9 @@ components: properties: table-name: type: string +timestamp-millis:

Re: [PR] Core: Add commit timestamp to CommitReport [iceberg]

2025-05-07 Thread via GitHub
nastra commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2078944246 ## core/src/main/java/org/apache/iceberg/metrics/CommitReportParser.java: ## @@ -26,6 +26,7 @@ public class CommitReportParser { private static final String TABL

Re: [PR] Core: Add commit timestamp to CommitReport [iceberg]

2025-05-06 Thread via GitHub
nastra commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2076833232 ## .palantir/revapi.yml: ## @@ -1178,6 +1178,9 @@ acceptedBreaks: new: "class org.apache.iceberg.Metrics" justification: "Java serialization across versi

Re: [PR] Core: Add commit timestamp to CommitReport [iceberg]

2025-05-06 Thread via GitHub
nastra commented on code in PR #12990: URL: https://github.com/apache/iceberg/pull/12990#discussion_r2076832653 ## core/src/main/java/org/apache/iceberg/metrics/CommitReport.java: ## @@ -27,6 +27,8 @@ public interface CommitReport extends MetricsReport { String tableName();

[PR] Core: Add commit timestamp to CommitReport [iceberg]

2025-05-06 Thread via GitHub
manuzhang opened a new pull request, #12990: URL: https://github.com/apache/iceberg/pull/12990 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,