Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-04-09 Thread via GitHub
amogh-jahagirdar commented on PR #9273: URL: https://github.com/apache/iceberg/pull/9273#issuecomment-2045466272 Sorry for the delay on reviewing this @manuzhang thanks for adding this, I think the environment details in the summary will be quite helpful. I'll go ahead and merge. Thanks @na

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-04-09 Thread via GitHub
amogh-jahagirdar merged PR #9273: URL: https://github.com/apache/iceberg/pull/9273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-03-26 Thread via GitHub
nastra commented on PR #9273: URL: https://github.com/apache/iceberg/pull/9273#issuecomment-2019859878 @amogh-jahagirdar or @RussellSpitzer can you guys also take a look at this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-03-25 Thread via GitHub
manuzhang commented on PR #9273: URL: https://github.com/apache/iceberg/pull/9273#issuecomment-2019398747 @nastra how can we move this forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-02-22 Thread via GitHub
nastra commented on code in PR #9273: URL: https://github.com/apache/iceberg/pull/9273#discussion_r1498980055 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -848,6 +850,19 @@ public void testRewriteWith

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-02-21 Thread via GitHub
nastra commented on code in PR #9273: URL: https://github.com/apache/iceberg/pull/9273#discussion_r1497064767 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -109,6 +110,7 @@ public void testRewriteDataFi

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-02-21 Thread via GitHub
manuzhang commented on code in PR #9273: URL: https://github.com/apache/iceberg/pull/9273#discussion_r1497056414 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -109,6 +110,7 @@ public void testRewriteDat

Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

2024-02-20 Thread via GitHub
nastra commented on code in PR #9273: URL: https://github.com/apache/iceberg/pull/9273#discussion_r1497028069 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ## @@ -109,6 +110,7 @@ public void testRewriteDataFi