manuzhang commented on code in PR #9273: URL: https://github.com/apache/iceberg/pull/9273#discussion_r1497056414
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ########## @@ -109,6 +110,7 @@ public void testRewriteDataFilesOnPartitionTable() { List<Object[]> actualRecords = currentData(); assertEquals("Data after compaction should not change", expectedRecords, actualRecords); + assertThat(snapshotSummary()).containsKey(CatalogProperties.APP_ID); Review Comment: @ajantha-bhat suggested adding validation instead of a separate test not to increase CI time. I'm ok with both ways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org