Fokko merged PR #11514:
URL: https://github.com/apache/iceberg/pull/11514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1853645488
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1081,8 +1094,18 @@ public Builder setCurrentSchema(int schemaId) {
return this;
}
+
Fokko commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1853643848
##
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##
@@ -462,6 +465,8 @@ private static MetadataUpdate readAddSchema(JsonNode node) {
Schema sche
rdblue commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1852719762
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1081,8 +1094,18 @@ public Builder setCurrentSchema(int schemaId) {
return this;
}
+
rdblue commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1852718855
##
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##
@@ -462,6 +465,8 @@ private static MetadataUpdate readAddSchema(JsonNode node) {
Schema sch
nastra commented on PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#issuecomment-2490255141
@hussein-awala the Schema API is part of `iceberg-core` and thus allows
things to be deprecated and then removed in the next minor release (see also
https://iceberg.apache.org/contribute
nastra commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1850551275
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -562,10 +562,23 @@ public TableMetadata withUUID() {
return new Builder(this).assignUUID().buil
Fokko commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1850688084
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1081,8 +1094,18 @@ public Builder setCurrentSchema(int schemaId) {
return this;
}
+
nastra commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1850550600
##
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##
@@ -462,6 +465,8 @@ private static MetadataUpdate readAddSchema(JsonNode node) {
Schema sch
Fokko commented on PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#issuecomment-2478125759
@danielcweeks You're right! I wanted to show that after updating the code,
all the existing tests still pass.
I've updated the tests in a separate commit
https://github.com/apache
Fokko commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1843296963
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2692,7 +2692,14 @@ components:
$ref: '#/components/schemas/Schema'
last-column-id:
type: i
danielcweeks commented on PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#issuecomment-2477166647
@Fokko as part of the proposed deprecation, we should update all tests that
use this (I found multiple references).
--
This is an automated message from the Apache Git Service.
T
danielcweeks commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1842725865
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2692,7 +2692,14 @@ components:
$ref: '#/components/schemas/Schema'
last-column-id:
Fokko commented on PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#issuecomment-2470445349
> Do we have anyone or any implementations which benefit from having it
there?
I have the same question, I can't think of why you need to set this
externally.
--
This is an auto
RussellSpitzer commented on PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#issuecomment-2468828703
I did not understand why this was there before. Do we have anyone or any
implementations which benefit from having it there?
--
This is an automated message from the Apache Git
Fokko opened a new pull request, #11514:
URL: https://github.com/apache/iceberg/pull/11514
Okay, I've added this to the spec a while ago:
https://github.com/apache/iceberg/pull/7445
But I think this was a mistake, and we should not expose this to the public
APIs, as it is much
16 matches
Mail list logo
