rdblue commented on code in PR #11514: URL: https://github.com/apache/iceberg/pull/11514#discussion_r1852718855
########## core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java: ########## @@ -462,6 +465,8 @@ private static MetadataUpdate readAddSchema(JsonNode node) { Schema schema = SchemaParser.fromJson(schemaNode); int lastColumnId; if (node.has(LAST_COLUMN_ID)) { + LOG.warn( + "Field last-column-id of MetadataUpdate.AddSchema is deprecated since Iceberg 1.8.0, will be removed in 1.9.0 or 2.0.0"); Review Comment: Do we need to warn on every update? This is going to fill service logs. We should just ignore this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org