Re: [PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-27 Thread via GitHub
aokolnychyi commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436832637 ## core/src/main/java/org/apache/iceberg/deletes/DeleteGranularity.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-27 Thread via GitHub
aokolnychyi commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436831824 ## core/src/main/java/org/apache/iceberg/deletes/DeleteGranularity.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-26 Thread via GitHub
zinking commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436689974 ## core/src/main/java/org/apache/iceberg/deletes/TargetedPositionDeleteWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-26 Thread via GitHub
zinking commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436689327 ## core/src/main/java/org/apache/iceberg/deletes/DeleteGranularity.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-26 Thread via GitHub
aokolnychyi commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436606528 ## core/src/main/java/org/apache/iceberg/io/FanoutPositionOnlyDeleteWriter.java: ## @@ -49,21 +51,32 @@ public FanoutPositionOnlyDeleteWriter( OutputFileFact

Re: [PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-26 Thread via GitHub
aokolnychyi commented on code in PR #9384: URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436606249 ## core/src/main/java/org/apache/iceberg/TableProperties.java: ## @@ -334,6 +335,9 @@ private TableProperties() {} public static final String MAX_REF_AGE_MS = "h

[PR] Core, Spark 3.5: Support file and partition delete granularity [iceberg]

2023-12-26 Thread via GitHub
aokolnychyi opened a new pull request, #9384: URL: https://github.com/apache/iceberg/pull/9384 This PR adds support for file and partition delete granularity, allowing users to pick between the two. Under partition granularity, delete writers are allowed to group deletes for differen