aokolnychyi commented on code in PR #9384:
URL: https://github.com/apache/iceberg/pull/9384#discussion_r1436606528
##########
core/src/main/java/org/apache/iceberg/io/FanoutPositionOnlyDeleteWriter.java:
##########
@@ -49,21 +51,32 @@ public FanoutPositionOnlyDeleteWriter(
OutputFileFactory fileFactory,
FileIO io,
long targetFileSizeInBytes) {
+ this(writerFactory, fileFactory, io, targetFileSizeInBytes,
DeleteGranularity.PARTITION);
+ }
+
+ public FanoutPositionOnlyDeleteWriter(
+ FileWriterFactory<T> writerFactory,
+ OutputFileFactory fileFactory,
+ FileIO io,
+ long targetFileSizeInBytes,
+ DeleteGranularity granularity) {
this.writerFactory = writerFactory;
this.fileFactory = fileFactory;
this.io = io;
this.targetFileSizeInBytes = targetFileSizeInBytes;
+ this.granularity = granularity;
this.deleteFiles = Lists.newArrayList();
this.referencedDataFiles = CharSequenceSet.empty();
}
@Override
protected FileWriter<PositionDelete<T>, DeleteWriteResult> newWriter(
PartitionSpec spec, StructLike partition) {
- FileWriter<PositionDelete<T>, DeleteWriteResult> delegate =
- new RollingPositionDeleteWriter<>(
- writerFactory, fileFactory, io, targetFileSizeInBytes, spec,
partition);
- return new SortingPositionOnlyDeleteWriter<>(delegate);
+ return new SortingPositionOnlyDeleteWriter<>(
+ () ->
Review Comment:
I don't like how this part is formatted but I don't have a better way. Ideas
welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
