Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

Fokko merged PR #11522: URL: https://github.com/apache/iceberg/pull/11522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

github-actions[bot] commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2585490669 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

munendrasn commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2538453726 @danielcweeks could you please review again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872744712 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java: ## @@ -249,6 +251,39 @@ public void testSocketAndConnectionTimeoutSet() { assertThat(connectio

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872744326 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java: ## @@ -249,6 +251,39 @@ public void testSocketAndConnectionTimeoutSet() { assertThat(connectio

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

munendrasn commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872760707 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -465,10 +465,16 @@ static HttpClientConnectionManager configureConnectionManager(Map

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872744326 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java: ## @@ -249,6 +251,39 @@ public void testSocketAndConnectionTimeoutSet() { assertThat(connectio

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872744712 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java: ## @@ -249,6 +251,39 @@ public void testSocketAndConnectionTimeoutSet() { assertThat(connectio

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872742980 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -465,10 +465,16 @@ static HttpClientConnectionManager configureConnectionManager(Map

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872743232 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -465,10 +465,16 @@ static HttpClientConnectionManager configureConnectionManager(Map

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

munendrasn commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872526373 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -78,10 +78,13 @@ public class HTTPClient implements RESTClient { static final String CLIENT

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

danielcweeks commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1871747394 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -78,10 +78,13 @@ public class HTTPClient implements RESTClient { static final String CLIE

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

munendrasn commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2497965425 @nastra both are not directly related, This change addresses reading the maxConnection setting from properties passed, other one is support to read system properties on Apache httpCl

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2497950010 @munendrasn sorry, I meant https://github.com/apache/iceberg/pull/11548 (I've updated my earlier comment) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

munendrasn commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2497926515 @nastra >how is this change here related to https://github.com/apache/iceberg/pull/11522? Did you mean https://github.com/apache/iceberg/pull/9195, the PR from description

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

nastra commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2497921659 @munendrasn how is this change here related to https://github.com/apache/iceberg/pull/11522? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Core, Rest: Read the max connection for rest client from properties [iceberg]

munendrasn commented on PR #11522: URL: https://github.com/apache/iceberg/pull/11522#issuecomment-2497812067 @nastra @amogh-jahagirdar could you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U