munendrasn commented on code in PR #11522: URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872526373
########## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ########## @@ -78,10 +78,13 @@ public class HTTPClient implements RESTClient { static final String CLIENT_GIT_COMMIT_SHORT_HEADER = "X-Client-Git-Commit-Short"; private static final String REST_MAX_RETRIES = "rest.client.max-retries"; - private static final String REST_MAX_CONNECTIONS = "rest.client.max-connections"; - private static final int REST_MAX_CONNECTIONS_DEFAULT = 100; - private static final String REST_MAX_CONNECTIONS_PER_ROUTE = "rest.client.connections-per-route"; - private static final int REST_MAX_CONNECTIONS_PER_ROUTE_DEFAULT = 100; + @VisibleForTesting static final String REST_MAX_CONNECTIONS = "rest.client.max-connections"; Review Comment: removed the annotation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org