Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-05-05 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2073415112 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-30 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2068340171 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-30 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2068307219 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2067958054 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriterBuilder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066040201 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066040536 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066023603 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066022181 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066013312 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2066004093 ## data/src/main/java/org/apache/iceberg/data/PositionDeleteWriterBuilder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-29 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2065986466 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-23 Thread via GitHub
wgtmac commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2057631093 ## data/src/main/java/org/apache/iceberg/data/AppenderBuilder.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-04-21 Thread via GitHub
liurenjie1024 commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2045976962 ## data/src/main/java/org/apache/iceberg/data/ObjectModelRegistry.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one