Fokko commented on PR #388:
URL: https://github.com/apache/iceberg-python/pull/388#issuecomment-1933613521
This is much better, thanks @HonahX for working on this. Let's get this in,
so we don't break the references later on.
--
This is an automated message from the Apache Git Service.
To
Fokko merged PR #388:
URL: https://github.com/apache/iceberg-python/pull/388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
HonahX commented on PR #388:
URL: https://github.com/apache/iceberg-python/pull/388#issuecomment-1933296601
> this is awesome! Slight nit, it is better code organization-wise to move
the properties to something like `table/properties.py`? just so that properties
are easier to find. `table/_
Fokko commented on code in PR #388:
URL: https://github.com/apache/iceberg-python/pull/388#discussion_r1481153291
##
pyiceberg/table/__init__.py:
##
@@ -1493,7 +1536,8 @@ def union_by_name(self, new_schema: Union[Schema,
"pa.Schema"]) -> UpdateSchema:
visit_with_partne
HonahX opened a new pull request, #388:
URL: https://github.com/apache/iceberg-python/pull/388
Fixes #365
My initial plan was to add the names and defaults of all table properties.
However, upon further consideration, I think it may be better to add properties
as needed.
--
This
