HonahX commented on PR #388: URL: https://github.com/apache/iceberg-python/pull/388#issuecomment-1933296601
> this is awesome! Slight nit, it is better code organization-wise to move the properties to something like `table/properties.py`? just so that properties are easier to find. `table/__init__.py` is already 2.5k lines long @kevinjqliu Thanks for the review! According to https://github.com/apache/iceberg-python/issues/365#issuecomment-1928022429, the purpose of putting properties in `table/__init__.py` is to avoid reduced import speed caused by the new file. I totally agree that we should make these properties easy to find. So I put the class at the top of the file. Does this look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
