Fokko merged PR #12348:
URL: https://github.com/apache/iceberg/pull/12348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#issuecomment-2684745027
Looks good, thanks @Kontinuation for working on this, and thanks @manuzhang
and @nastra for the review!
--
This is an automated message from the Apache Git Service.
To respond to the me
Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1966100776
##
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java:
##
@@ -118,6 +120,7 @@ public void testStreamingWriteAppendMode()
Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1966100776
##
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java:
##
@@ -118,6 +120,7 @@ public void testStreamingWriteAppendMode()
Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1966100776
##
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java:
##
@@ -118,6 +120,7 @@ public void testStreamingWriteAppendMode()
Kontinuation commented on PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#issuecomment-2675434683
> The title sounds a bit strange to me. How about `Build: remove Hadoop 2
dependency`?
Renamed the title as requested.
--
This is an automated message from the Apache Git
Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1966100776
##
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java:
##
@@ -118,6 +120,7 @@ public void testStreamingWriteAppendMode()
Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1966038780
##
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##
@@ -87,7 +86,7 @@ static String md5sum(InputStream is) throws IOExcep
