Kontinuation commented on code in PR #12348:
URL: https://github.com/apache/iceberg/pull/12348#discussion_r1966038780
##########
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##########
@@ -87,7 +86,7 @@ static String md5sum(InputStream is) throws IOException {
while ((numBytes = is.read(bytes)) != -1) {
md.update(bytes, 0, numBytes);
}
- return new String(Hex.encodeHex(md.digest())).toUpperCase(Locale.ROOT);
+ return Hex.encodeHexString(md.digest(), false);
Review Comment:
`org.apache.directory.api.util.Hex` is not available after switching to
Hadoop 3. Also, I think it is more reasonable to use a function from Apache
Commons for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
