Re: [PR] Build: Add checkstyle rule to ban assert usage [iceberg]

nastra merged PR #10886: URL: https://github.com/apache/iceberg/pull/10886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Build: Add checkstyle rule to ban assert usage [iceberg]

nastra commented on PR #10886: URL: https://github.com/apache/iceberg/pull/10886#issuecomment-2271669505 thanks for the reviews @findepi @bryanck @amogh-jahagirdar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Build: Add checkstyle rule to ban assert usage [iceberg]

nastra commented on code in PR #10886: URL: https://github.com/apache/iceberg/pull/10886#discussion_r1705611373 ## .baseline/checkstyle/checkstyle.xml: ## @@ -414,6 +414,11 @@ + + Review Comment: @findepi `LITERAL_ASS

Re: [PR] Build: Add checkstyle rule to ban assert usage [iceberg]

nastra commented on code in PR #10886: URL: https://github.com/apache/iceberg/pull/10886#discussion_r1705585282 ## .baseline/checkstyle/checkstyle.xml: ## @@ -414,6 +414,11 @@ + + Review Comment: I don't think we want

Re: [PR] Build: Add checkstyle rule to ban assert usage [iceberg]

findepi commented on code in PR #10886: URL: https://github.com/apache/iceberg/pull/10886#discussion_r1705578042 ## .baseline/checkstyle/checkstyle.xml: ## @@ -414,6 +414,11 @@ + + Review Comment: can you give https:

Re: [PR] Build: Add checkstyle rule to ban assert usage [iceberg]

findepi commented on code in PR #10886: URL: https://github.com/apache/iceberg/pull/10886#discussion_r1705567611 ## .baseline/checkstyle/checkstyle.xml: ## @@ -414,6 +414,11 @@ + + Review Comment: current pattern