nastra commented on code in PR #10886: URL: https://github.com/apache/iceberg/pull/10886#discussion_r1705611373
########## .baseline/checkstyle/checkstyle.xml: ########## @@ -414,6 +414,11 @@ <property name="format" value="@Test\(.*expected.*\)"/> <property name="message" value="Prefer using Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/> </module> + <module name="RegexpSinglelineJava"> + <property name="format" value="^\s*assert\s+"/> Review Comment: @findepi `LITERAL_ASSERT` does the trick and is much better than regex matching, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org