Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-16 Thread via GitHub
danielcweeks merged PR #11844: URL: https://github.com/apache/iceberg/pull/11844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-16 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1918180693 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917315859 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917315859 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917092295 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917090457 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1917015969 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1916787886 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-15 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1916787886 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-13 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1912976403 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910786713 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910776037 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
danielcweeks commented on PR #11844: URL: https://github.com/apache/iceberg/pull/11844#issuecomment-2583299516 @adutra Just one last comment on the thread pool, but other than that this look good to go. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910677023 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910657206 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -21,15 +21,16 @@ import java.util.Map; import javax.annotation.Nullable; import org.

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
nastra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910233419 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -21,15 +21,16 @@ import java.util.Map; import javax.annotation.Nullable; import org.apache

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910192769 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-10 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1910190967 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -21,15 +21,16 @@ import java.util.Map; import javax.annotation.Nullable; import org.apache

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-09 Thread via GitHub
nastra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1909181281 ## core/src/main/java/org/apache/iceberg/rest/auth/RefreshingAuthManager.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-09 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1909568642 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-09 Thread via GitHub
danielcweeks commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1909453326 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -21,15 +21,16 @@ import java.util.Map; import javax.annotation.Nullable; import org.

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2025-01-03 Thread via GitHub
johnnysohn commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1901683532 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthManagers.java: ## @@ -42,6 +57,9 @@ public static AuthManager loadAuthManager(String name, Map prope

Re: [PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2024-12-28 Thread via GitHub
adutra commented on code in PR #11844: URL: https://github.com/apache/iceberg/pull/11844#discussion_r1898887643 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthManagers.java: ## @@ -42,6 +57,9 @@ public static AuthManager loadAuthManager(String name, Map prope cas

[PR] Auth Manager API part 3: OAuth2 Manager [iceberg]

2024-12-21 Thread via GitHub
adutra opened a new pull request, #11844: URL: https://github.com/apache/iceberg/pull/11844 3rd PR for the Auth Manager API. Previous ones: * #11809 * #11769 This PR introduces the `OAuth2Manager` along with session caching and credentials refreshing. It is still "unplugged