johnnysohn commented on code in PR #11844:
URL: https://github.com/apache/iceberg/pull/11844#discussion_r1901683532


##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthManagers.java:
##########
@@ -42,6 +57,9 @@ public static AuthManager loadAuthManager(String name, 
Map<String, String> prope
       case AuthProperties.AUTH_TYPE_BASIC:
         impl = AuthProperties.AUTH_MANAGER_IMPL_BASIC;
         break;
+      case AuthProperties.AUTH_TYPE_OAUTH2:
+        impl = AuthProperties.AUTH_MANAGER_IMPL_OAUTH2;
+        break;
       default:
         impl = authType;

Review Comment:
   Yes that works! I wasn't sure whether you were planning on having authType 
for as a name of the type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to