Re: [PR] Arrow: Don't copy the list when not needed [iceberg-python]

2024-01-25 Thread via GitHub
Fokko commented on code in PR #252: URL: https://github.com/apache/iceberg-python/pull/252#discussion_r1467065763 ## pyiceberg/io/pyarrow.py: ## @@ -1152,24 +1163,31 @@ def field(self, field: NestedField, _: Optional[pa.Array], field_array: Optional return field_array

Re: [PR] Arrow: Don't copy the list when not needed [iceberg-python]

2024-01-24 Thread via GitHub
Fokko commented on code in PR #252: URL: https://github.com/apache/iceberg-python/pull/252#discussion_r1465502918 ## pyiceberg/io/pyarrow.py: ## @@ -1152,24 +1163,31 @@ def field(self, field: NestedField, _: Optional[pa.Array], field_array: Optional return field_array

Re: [PR] Arrow: Don't copy the list when not needed [iceberg-python]

2024-01-24 Thread via GitHub
HonahX commented on code in PR #252: URL: https://github.com/apache/iceberg-python/pull/252#discussion_r1464527694 ## pyiceberg/io/pyarrow.py: ## @@ -1152,24 +1163,31 @@ def field(self, field: NestedField, _: Optional[pa.Array], field_array: Optional return field_array

Re: [PR] Arrow: Don't copy the list when not needed [iceberg-python]

2024-01-24 Thread via GitHub
HonahX commented on code in PR #252: URL: https://github.com/apache/iceberg-python/pull/252#discussion_r1464482344 ## pyiceberg/io/pyarrow.py: ## @@ -1152,24 +1163,31 @@ def field(self, field: NestedField, _: Optional[pa.Array], field_array: Optional return field_array