Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-18 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1457609164 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-18 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1457593015 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-18 Thread via GitHub
Fokko commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1457510803 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[U

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-17 Thread via GitHub
HonahX commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1456947775 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-17 Thread via GitHub
HonahX commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1456922888 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-17 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1456437583 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-16 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1453725520 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-16 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1453725520 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-16 Thread via GitHub
Fokko commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1453593588 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[U

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-16 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1453579122 ## pyiceberg/io/pyarrow.py: ## @@ -733,42 +854,178 @@ def _get_field_id(field: pa.Field) -> Optional[int]: ) -class _ConvertToIceberg(PyArrowSchemaVisitor[

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-16 Thread via GitHub
syun64 commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1453543090 ## pyiceberg/table/__init__.py: ## @@ -831,6 +832,13 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool =

Re: [PR] Apply Name mapping, new_schema_for_table [iceberg-python]

2024-01-15 Thread via GitHub
Fokko commented on code in PR #219: URL: https://github.com/apache/iceberg-python/pull/219#discussion_r1452677656 ## pyiceberg/table/__init__.py: ## @@ -831,6 +832,13 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool =