Re: [PR] Aliyun: Replace assert usage with assertThat [iceberg]

2024-08-05 Thread via GitHub
findepi commented on code in PR #10880: URL: https://github.com/apache/iceberg/pull/10880#discussion_r1704567580 ## aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java: ## @@ -170,17 +174,21 @@ ObjectMetadata putObject( void deleteObject(Str

Re: [PR] Aliyun: Replace assert usage with assertThat [iceberg]

2024-08-05 Thread via GitHub
nastra merged PR #10880: URL: https://github.com/apache/iceberg/pull/10880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Aliyun: Replace assert usage with assertThat [iceberg]

2024-08-05 Thread via GitHub
nastra commented on PR #10880: URL: https://github.com/apache/iceberg/pull/10880#issuecomment-2269678978 thanks for the review @findepi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Aliyun: Replace assert usage with assertThat [iceberg]

2024-08-05 Thread via GitHub
nastra commented on code in PR #10880: URL: https://github.com/apache/iceberg/pull/10880#discussion_r1704500449 ## aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java: ## @@ -170,17 +174,21 @@ ObjectMetadata putObject( void deleteObject(Stri

Re: [PR] Aliyun: Replace assert usage with assertThat [iceberg]

2024-08-05 Thread via GitHub
findepi commented on code in PR #10880: URL: https://github.com/apache/iceberg/pull/10880#discussion_r1704491193 ## aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java: ## @@ -170,17 +174,21 @@ ObjectMetadata putObject( void deleteObject(Str