nastra commented on code in PR #10880:
URL: https://github.com/apache/iceberg/pull/10880#discussion_r1704500449
##########
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##########
@@ -170,17 +174,21 @@ ObjectMetadata putObject(
void deleteObject(String bucketName, String filename) {
File bucketDir = new File(root, bucketName);
- assert bucketDir.exists();
Review Comment:
nope, there's no real advantange in using the `assert` statement.
Additionally, they aren't enabled so these checks have actually never be
performed. We might actually want to add a checkstyle rule to prevent usage of
`assert` in Java code (I'll open a separate PR for that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
