Re: [PR] Added support for lowercase FileFormat for Issue #1340 [iceberg-python]

2025-01-15 Thread via GitHub
kevinjqliu commented on PR #1362: URL: https://github.com/apache/iceberg-python/pull/1362#issuecomment-2593417593 @Fokko this PR is failing CI https://github.com/apache/iceberg-python/actions/runs/12792587045/job/35663397601 I also tested that it fails locally. We might need to revert thi

Re: [PR] Added support for lowercase FileFormat for Issue #1340 [iceberg-python]

2025-01-15 Thread via GitHub
Fokko merged PR #1362: URL: https://github.com/apache/iceberg-python/pull/1362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Added support for lowercase FileFormat for Issue #1340 [iceberg-python]

2025-01-15 Thread via GitHub
Fokko commented on code in PR #1362: URL: https://github.com/apache/iceberg-python/pull/1362#discussion_r1916928078 ## pyiceberg/manifest.py: ## @@ -93,9 +93,16 @@ def __repr__(self) -> str: class FileFormat(str, Enum): -AVRO = "AVRO" -PARQUET = "PARQUET" -ORC =

Re: [PR] Added support for lowercase FileFormat for Issue #1340 [iceberg-python]

2024-12-11 Thread via GitHub
Fokko commented on PR #1362: URL: https://github.com/apache/iceberg-python/pull/1362#issuecomment-2537057846 @hgollakota It looks like there is a formatting issue, could you run `make lint`? :) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Added support for lowercase FileFormat for Issue #1340 [iceberg-python]

2024-11-22 Thread via GitHub
kevinjqliu commented on PR #1362: URL: https://github.com/apache/iceberg-python/pull/1362#issuecomment-2494228038 thanks for the contribution! do you mind adding a few test cases to validate the new behavior? in the original issue, the Datafile has to set `file_format` to uppercase.