Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-11-16 Thread via GitHub
github-actions[bot] commented on PR #10737: URL: https://github.com/apache/iceberg/pull/10737#issuecomment-2480862579 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-11-16 Thread via GitHub
github-actions[bot] closed pull request #10737: AddPartitionSpec: A new way to set new partition specs URL: https://github.com/apache/iceberg/pull/10737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-11-09 Thread via GitHub
github-actions[bot] commented on PR #10737: URL: https://github.com/apache/iceberg/pull/10737#issuecomment-2466519723 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-05 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703630708 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -62,15 +62,20 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec { priv

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703559470 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -62,15 +62,20 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec {

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703554438 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -62,15 +62,20 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec { priv

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703549673 ## core/src/test/java/org/apache/iceberg/TestTableUpdatePartitionSpec.java: ## @@ -90,6 +90,46 @@ public void testCommitUpdatedSpec() { assertThat(table.spec().

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703507372 ## core/src/test/java/org/apache/iceberg/TestTableUpdatePartitionSpec.java: ## @@ -90,6 +90,46 @@ public void testCommitUpdatedSpec() { assertThat(table.s

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703507104 ## core/src/test/java/org/apache/iceberg/TestTableUpdatePartitionSpec.java: ## @@ -90,6 +90,46 @@ public void testCommitUpdatedSpec() { assertThat(table.s

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703506059 ## core/src/test/java/org/apache/iceberg/TestTableUpdatePartitionSpec.java: ## @@ -90,6 +90,46 @@ public void testCommitUpdatedSpec() { assertThat(table.s

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703505303 ## core/src/test/java/org/apache/iceberg/TestTableUpdatePartitionSpec.java: ## @@ -90,6 +90,46 @@ public void testCommitUpdatedSpec() { assertThat(table.s

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703504713 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -62,15 +62,20 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec {

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703502870 ## api/src/main/java/org/apache/iceberg/UpdatePartitionSpec.java: ## @@ -29,6 +29,7 @@ * will not be resolved and will result in a {@link CommitFailedExcepti

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-08-04 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1703493428 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec { th

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-31 Thread via GitHub
jasonf20 commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1698628505 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec { th

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-31 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1698599115 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec {

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-31 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1698579700 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec { th

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-31 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1698550513 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec { th

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-29 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1695794990 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec {

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-29 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1695790388 ## core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java: ## @@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements UpdatePartitionSpec {

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-27 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1694103029 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-27 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1694103029 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-27 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1694103029 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-25 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1691611196 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-23 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1689195839 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-23 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1688994691 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-23 Thread via GitHub
shanielh commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1688993988 ## api/src/main/java/org/apache/iceberg/Transaction.java: ## @@ -44,6 +44,13 @@ public interface Transaction { */ UpdatePartitionSpec updateSpec(); + /** +

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-23 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1688720424 ## api/src/main/java/org/apache/iceberg/AddPartitionSpec.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-23 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1688708763 ## api/src/main/java/org/apache/iceberg/Transaction.java: ## @@ -44,6 +44,13 @@ public interface Transaction { */ UpdatePartitionSpec updateSpec(); +

Re: [PR] AddPartitionSpec: A new way to set new partition specs [iceberg]

2024-07-23 Thread via GitHub
RussellSpitzer commented on code in PR #10737: URL: https://github.com/apache/iceberg/pull/10737#discussion_r1688711598 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -183,6 +183,14 @@ default IncrementalChangelogScan newIncrementalChangelogScan() { */ UpdateP