shanielh commented on code in PR #10737:
URL: https://github.com/apache/iceberg/pull/10737#discussion_r1698550513
##########
core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java:
##########
@@ -66,20 +66,36 @@ class BaseUpdatePartitionSpec implements
UpdatePartitionSpec {
this.caseSensitive = true;
this.base = ops.current();
this.formatVersion = base.formatVersion();
- this.spec = base.spec();
+ fromSpec(base.spec());
+ }
+
+ @Override
+ public UpdatePartitionSpec fromSpec(PartitionSpec partitionSpec) {
+ // Clear all changes
Review Comment:
> Implementation wise, I would rather we return a new object here? Couldn't
we add a constructor
>
> BaseUpdatePartitionSpec(TableOperations ops, PartitionSpec spec)
>
> That way we could keep all of the variables above final?
Modified and fixed revApi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
