Re: [PR] Add table statistics [iceberg-python]

2025-01-16 Thread via GitHub
Fokko merged PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Add table statistics [iceberg-python]

2025-01-15 Thread via GitHub
Fokko commented on code in PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#discussion_r1916863476 ## dev/provision.py: ## @@ -401,3 +401,27 @@ ) spark.sql(f"ALTER TABLE {catalog_name}.default.test_empty_scan_ordered_str WRITE ORDERED BY id") spa

Re: [PR] Add table statistics [iceberg-python]

2025-01-08 Thread via GitHub
ndrluis commented on PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#issuecomment-2578671151 @kevinjqliu Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add table statistics [iceberg-python]

2025-01-07 Thread via GitHub
kevinjqliu commented on PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#issuecomment-2576706997 @ndrluis do you mind resolving the merge conflict here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add table statistics [iceberg-python]

2024-11-12 Thread via GitHub
ndrluis commented on code in PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#discussion_r1838046096 ## mkdocs/docs/api.md: ## @@ -1129,6 +1129,28 @@ with table.manage_snapshots() as ms: ms.create_branch(snapshot_id1, "Branch_A").create_tag(snapshot_id2, "

Re: [PR] Add table statistics [iceberg-python]

2024-11-12 Thread via GitHub
ndrluis commented on PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#issuecomment-2470432842 > Do you know which engine currently can generate puffin files? would be great to add an integration with a spark generated puffin file @kevinjqliu As far as I know, only Tri

Re: [PR] Add table statistics [iceberg-python]

2024-11-11 Thread via GitHub
kevinjqliu commented on code in PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#discussion_r1837496028 ## mkdocs/docs/api.md: ## @@ -1129,6 +1129,28 @@ with table.manage_snapshots() as ms: ms.create_branch(snapshot_id1, "Branch_A").create_tag(snapshot_id2,

Re: [PR] Add table statistics [iceberg-python]

2024-11-10 Thread via GitHub
ndrluis commented on PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#issuecomment-2466990871 @kevinjqliu could you please review it once more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add table statistics [iceberg-python]

2024-11-03 Thread via GitHub
ndrluis commented on PR #1285: URL: https://github.com/apache/iceberg-python/pull/1285#issuecomment-2453710152 I plan to move the set/remove statistics methods from the Transaction class to another class, such as ManageSnapshot. In the meantime, I’d like to confirm with everyone if I’m head