kevinjqliu commented on code in PR #1285:
URL: https://github.com/apache/iceberg-python/pull/1285#discussion_r1837496028
##########
mkdocs/docs/api.md:
##########
@@ -1129,6 +1129,28 @@ with table.manage_snapshots() as ms:
ms.create_branch(snapshot_id1, "Branch_A").create_tag(snapshot_id2,
"tag789")
```
+## Table Statistics Management
+
+Manage table statistics with operations through the `Table` API:
+
+```python
+# To run a specific operation
+table.update_statistics().set_statistics(snapshot_id, statistics_file).commit()
+# To run multiple operations
+table.update_statistics()
+ .set_statistics(snapshot_id1, statistics_file1)
+ .remove_statistics(snapshot_id2)
+# Operations are applied on commit.
Review Comment:
nit: add `.commit()` instead of the comment
##########
mkdocs/docs/api.md:
##########
@@ -1129,6 +1129,28 @@ with table.manage_snapshots() as ms:
ms.create_branch(snapshot_id1, "Branch_A").create_tag(snapshot_id2,
"tag789")
```
+## Table Statistics Management
+
+Manage table statistics with operations through the `Table` API:
+
+```python
+# To run a specific operation
+table.update_statistics().set_statistics(snapshot_id, statistics_file).commit()
+# To run multiple operations
+table.update_statistics()
+ .set_statistics(snapshot_id1, statistics_file1)
+ .remove_statistics(snapshot_id2)
+# Operations are applied on commit.
+```
+
+You can also use context managers to make more changes:
+
+```python
+with table.update_statistics() as update:
+ update.set_statistics(1, statistics_file)
+ update.remove_statistics(2)
Review Comment:
nit: replace `1`/`2` with `snapshot_id1`/`snapshot_id2` to show the input
relation
##########
pyiceberg/table/statistics.py:
##########
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from typing import (
+ Dict,
+ List,
+ Optional,
+)
+
+from pydantic import Field
+
+from pyiceberg.typedef import IcebergBaseModel
+
+
+class BlobMetadata(IcebergBaseModel):
+ type: str
+ snapshot_id: int = Field(alias="snapshot-id")
+ sequence_number: int = Field(alias="sequence-number")
+ fields: List[int]
+ properties: Optional[Dict[str, str]] = None
+
+
+class StatisticsFile(IcebergBaseModel):
+ snapshot_id: int = Field(alias="snapshot-id")
+ statistics_path: str = Field(alias="statistics-path")
+ file_size_in_bytes: int = Field(alias="file-size-in-bytes")
+ file_footer_size_in_bytes: int = Field(alias="file-footer-size-in-bytes")
+ key_metadata: Optional[str] = Field(alias="key-metadata", default=None)
+ blob_metadata: List[BlobMetadata] = Field(alias="blob-metadata")
+
+
+def reject_statistics(
Review Comment:
nit: how about `filter_statistics_by_snapshot_id`?
##########
mkdocs/docs/api.md:
##########
@@ -1129,6 +1129,28 @@ with table.manage_snapshots() as ms:
ms.create_branch(snapshot_id1, "Branch_A").create_tag(snapshot_id2,
"tag789")
```
+## Table Statistics Management
+
+Manage table statistics with operations through the `Table` API:
+
+```python
+# To run a specific operation
+table.update_statistics().set_statistics(snapshot_id, statistics_file).commit()
+# To run multiple operations
+table.update_statistics()
+ .set_statistics(snapshot_id1, statistics_file1)
+ .remove_statistics(snapshot_id2)
+# Operations are applied on commit.
Review Comment:
or use `snapshot_id=1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
