Fokko commented on code in PR #2215:
URL: https://github.com/apache/iceberg-python/pull/2215#discussion_r2209225047
##
pyiceberg/utils/schema_conversion.py:
##
@@ -68,8 +68,9 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): DateTyp
matthias-Q commented on code in PR #2215:
URL: https://github.com/apache/iceberg-python/pull/2215#discussion_r2209205958
##
pyiceberg/utils/schema_conversion.py:
##
@@ -68,8 +68,9 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): Da
matthias-Q commented on code in PR #2215:
URL: https://github.com/apache/iceberg-python/pull/2215#discussion_r2209204616
##
tests/utils/test_schema_conversion.py:
##
@@ -341,8 +342,20 @@ def test_convert_uuid_fixed_type() -> None:
assert actual == UUIDType()
+def test_c
kevinjqliu commented on PR #2215:
URL: https://github.com/apache/iceberg-python/pull/2215#issuecomment-3075835601
looks like the linter failed, could you run `make lint`?
```
ruff (legacy
alias)..Failed
- hook id: ruff
- exit c
kevinjqliu commented on code in PR #2215:
URL: https://github.com/apache/iceberg-python/pull/2215#discussion_r2208730847
##
pyiceberg/utils/schema_conversion.py:
##
@@ -68,8 +68,9 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): Da
matthias-Q opened a new pull request, #2215:
URL: https://github.com/apache/iceberg-python/pull/2215
# Rationale for this change
* Fix schema_conversion for `timestamp-millis`
* add conversion for `time-millis`
Following up on #2173 the `timestamp-millis` is actually stored are `long
