matthias-Q commented on code in PR #2215:
URL: https://github.com/apache/iceberg-python/pull/2215#discussion_r2209205958
##########
pyiceberg/utils/schema_conversion.py:
##########
@@ -68,8 +68,9 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): DateType(),
+ ("time-millis", "int"): TimeType(),
("time-micros", "long"): TimeType(),
- ("timestamp-millis", "int"): TimestampType(),
+ ("timestamp-millis", "long"): TimestampType(),
Review Comment:
Interesting. I was just looking into the Avro Spec for logicalTypes and not
in the iceberg Java Code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
