Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 closed pull request #1193: Add datafusion cli for iceberg URL: https://github.com/apache/iceberg-rust/pull/1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 commented on PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#issuecomment-2796350792 In favor #1193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 opened a new pull request, #1193: URL: https://github.com/apache/iceberg-rust/pull/1193 ## Which issue does this PR close? - Closes #1142. ## What changes are included in this PR? Initial check in iceberg cli. -- This is an automated message from the

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 closed pull request #1143: Add datafusion cli for iceberg URL: https://github.com/apache/iceberg-rust/pull/1143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

xxchan commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2032308752 ## rust-toolchain.toml: ## Review Comment: I don't have strong opinions on this. It would be nice to have more frequent iceberg-rs releases. But it se

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2031156783 ## rust-toolchain.toml: ## Review Comment: > (imagine datafusion releases more frequently, and we can't bump MSRV until next release.) Do we ne

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

xxchan commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2030393097 ## rust-toolchain.toml: ## Review Comment: But it seems our new MSRV policy (3 month) can cover datafusion's 4 month policy, so maybe there's no need to have

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

xxchan commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2030391170 ## rust-toolchain.toml: ## Review Comment: Because currently we already use different MSRV for the datafusion integration. https://github.com/apache/i

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

xxchan commented on PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#issuecomment-2781902388 > > > * Closes [An iceberg cli tool  #1142](https://github.com/apache/iceberg-rust/issues/1142). > > > > > > Maybe we could have a tracking issue and create subtasks for feat

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 commented on PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#issuecomment-2781427563 Seems we have can't merge this since datafusion-cli requires newer version of rustc. We should postpone it after we release 0.5.0. -- This is an automated message from the Ap

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2030149688 ## rust-toolchain.toml: ## Review Comment: What's the benefit of this? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 commented on PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#issuecomment-2781418926 > > * Closes [An iceberg cli tool  #1142](https://github.com/apache/iceberg-rust/issues/1142). > > Maybe we could have a tracking issue and create subtasks for feature ide

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

xxchan commented on PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#issuecomment-2760624467 > * Closes [An iceberg cli tool  #1142](https://github.com/apache/iceberg-rust/issues/1142). Maybe we could have a tracking issue and create subtasks for features? -- This is

Re: [PR] Add datafusion cli for iceberg [iceberg-rust]

xxchan commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2018187420 ## rust-toolchain.toml: ## Review Comment: Maybe we can exclude `crates/integrations` from workspace, and have separate `rust-toolchain.toml` for them --

[PR] Add datafusion cli for iceberg [iceberg-rust]

liurenjie1024 opened a new pull request, #1143: URL: https://github.com/apache/iceberg-rust/pull/1143 ## Which issue does this PR close? - Closes #1142. ## What changes are included in this PR? Initial check in iceberg cli. ## Are these changes tested? Yes,