xxchan commented on code in PR #1143: URL: https://github.com/apache/iceberg-rust/pull/1143#discussion_r2030391170
########## rust-toolchain.toml: ########## Review Comment: Because currently we already use different MSRV for the datafusion integration. https://github.com/apache/iceberg-rust/blame/e1de63d3ec47ee97d2b22cd193634e9aa9ff6ed8/crates/integrations/datafusion/Cargo.toml#L23-L26 And in previous discussion: > We currently only have `msrv` for `iceberg`. I'm not sure if our goal is to maintain `msrv` for all our integration crates, such as `datafusion`. _Originally posted by @Xuanwo in https://github.com/apache/iceberg-rust/issues/849#issuecomment-2562880940_ You can see e.g., this PR is blocked by this. Actually we can upgrade the toolchain version used by the datafusion integration, without upgrading the project MSRV. And e.g., for the cli project, since it depends on the datafusion integration, it needs to use `max(project_msrv, datafusion_integration_msrv)`. That's why I proposed to just have a separate toolchain for all the integrations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
