Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on PR #296: URL: https://github.com/apache/iceberg-python/pull/296#issuecomment-1912081292 Thanks for the review @HonahX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko merged PR #296: URL: https://github.com/apache/iceberg-python/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467632051 ## pyiceberg/table/__init__.py: ## @@ -1995,6 +2020,159 @@ def primitive(self, primitive: PrimitiveType) -> Optional[IcebergType]: return primitive +cl

Re: [PR] Add UnionByName functionality [iceberg-python]

HonahX commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467318868 ## pyiceberg/table/__init__.py: ## @@ -1995,6 +2020,159 @@ def primitive(self, primitive: PrimitiveType) -> Optional[IcebergType]: return primitive +c

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467075837 ## pyiceberg/table/__init__.py: ## @@ -1398,14 +1401,23 @@ class UpdateSchema: def __init__( self, -table: Table, +table: Optional[Ta

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467075685 ## pyiceberg/table/__init__.py: ## @@ -1995,6 +2020,156 @@ def primitive(self, primitive: PrimitiveType) -> Optional[IcebergType]: return primitive +cl

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467074883 ## pyiceberg/table/__init__.py: ## @@ -1995,6 +2020,156 @@ def primitive(self, primitive: PrimitiveType) -> Optional[IcebergType]: return primitive +cl

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467074385 ## pyiceberg/table/__init__.py: ## @@ -1449,6 +1461,15 @@ def case_sensitive(self, case_sensitive: bool) -> UpdateSchema: self._case_sensitive = case_sensi

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467073434 ## pyiceberg/table/__init__.py: ## @@ -1995,6 +2020,156 @@ def primitive(self, primitive: PrimitiveType) -> Optional[IcebergType]: return primitive +cl

Re: [PR] Add UnionByName functionality [iceberg-python]

Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467071050 ## tests/test_schema.py: ## @@ -912,3 +914,668 @@ def test_promotion(file_type: IcebergType, read_type: IcebergType) -> None: else: with pytest.raises

Re: [PR] Add UnionByName functionality [iceberg-python]

HonahX commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1465867474 ## pyiceberg/table/__init__.py: ## @@ -1995,6 +2020,156 @@ def primitive(self, primitive: PrimitiveType) -> Optional[IcebergType]: return primitive +c

[PR] Add UnionByName functionality [iceberg-python]

Fokko opened a new pull request, #296: URL: https://github.com/apache/iceberg-python/pull/296 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e