Fokko commented on code in PR #296: URL: https://github.com/apache/iceberg-python/pull/296#discussion_r1467074385
########## pyiceberg/table/__init__.py: ########## @@ -1449,6 +1461,15 @@ def case_sensitive(self, case_sensitive: bool) -> UpdateSchema: self._case_sensitive = case_sensitive return self + def union_by_name(self, new_schema: Schema) -> UpdateSchema: + visit_with_partner( + new_schema, + -1, + UnionByNameVisitor(update_schema=self, new_schema=self._schema, case_sensitive=self._case_sensitive), # type: ignore Review Comment: Ah good catch, I think that was an error, thanks for spotting this 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org