Re: [PR] Add Thrift and Hive to NOTICE [iceberg-python]

2024-02-12 Thread via GitHub
rdblue commented on PR #410: URL: https://github.com/apache/iceberg-python/pull/410#issuecomment-1939148398 @Fokko, I think that this change is incorrect. It conflicts with the conventions that we use in Avro, Parquet, and the other Iceberg releases. LICENSE is where we put license informat

Re: [PR] Add Thrift and Hive to NOTICE [iceberg-python]

2024-02-12 Thread via GitHub
Fokko merged PR #410: URL: https://github.com/apache/iceberg-python/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add Thrift and Hive to NOTICE [iceberg-python]

2024-02-10 Thread via GitHub
Fokko commented on PR #410: URL: https://github.com/apache/iceberg-python/pull/410#issuecomment-1937387259 @danielcweeks I just replied on the mailing list. We do ship the Python-generated Thrift definitions that are stored here: https://github.com/apache/iceberg-python/tree/main/vendor

Re: [PR] Add Thrift and Hive to NOTICE [iceberg-python]

2024-02-10 Thread via GitHub
danielcweeks commented on PR #410: URL: https://github.com/apache/iceberg-python/pull/410#issuecomment-1937383779 @Fokko I'm not sure this is necessary since we don't actually bundle any thing in the project. Per the [ASF site](https://infra.apache.org/licensing-howto.html#bundled-vs-non-b

[PR] Add Thrift and Hive to NOTICE [iceberg-python]

2024-02-10 Thread via GitHub
Fokko opened a new pull request, #410: URL: https://github.com/apache/iceberg-python/pull/410 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e