Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks merged PR #11093: URL: https://github.com/apache/iceberg/pull/11093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1852643846 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1852627137 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

c-thiel commented on PR #11093: URL: https://github.com/apache/iceberg/pull/11093#issuecomment-2490793742 @nastra, @danielcweeks is there something stopping us from merging this? This is currently blocking us on https://github.com/apache/iceberg/pull/11317 which is a requirement for REST

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1842726587 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1842636900 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1841393266 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1841394148 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1841393266 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,20 +87,29 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on PR #11093: URL: https://github.com/apache/iceberg/pull/11093#issuecomment-2468874987 @danielcweeks All comments adopted, feel free to take another look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1825102384 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -107,4 +116,18 @@ static void purgeCatalogTestEntries(RESTCatalog catalog) {

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1825101193 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +86,30 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1825097791 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -107,4 +116,18 @@ static void purgeCatalogTestEntries(RESTCatalog catalog) {

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1825086332 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,16 +41,46 @@ import org.apache.iceberg.catalog.SupportsNamespaces

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1824745679 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +86,30 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on PR #11093: URL: https://github.com/apache/iceberg/pull/11093#issuecomment-2450262762 Hey @haizhou-zhao this is looking really close. Some minor comments on how I think we can improve the Extension handling to better isolate the test, but other than that, I think i

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1824749990 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -76,15 +78,22 @@ static Map environmentCatalogConfig() { HashMap:

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1824745679 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +86,30 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1824745679 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +86,30 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1824709276 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java: ## @@ -107,4 +116,18 @@ static void purgeCatalogTestEntries(RESTCatalog catalog) {

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823802445 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,17 +41,37 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823797130 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,17 +41,37 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823798343 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +84,30 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823798127 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,17 +41,37 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823793249 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +94,28 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823795448 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,17 +41,38 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823794984 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,16 +41,46 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823794365 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,16 +41,46 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823794001 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,16 +41,46 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823793249 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +94,28 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823793865 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +94,28 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823793733 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +94,28 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823145510 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,16 +42,55 @@ import org.apache.iceberg.catalog.SupportsNamespaces

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1823145272 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -18,13 +18,19 @@ */ package org.apache.iceberg.spark; +import sta

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1822138079 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -18,13 +18,19 @@ */ package org.apache.iceberg.spark; +import static or

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1822139250 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -36,16 +42,55 @@ import org.apache.iceberg.catalog.SupportsNamespaces; imp

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1822131912 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -37,12 +38,19 @@ public class RESTCatalogServer { private static final Logg

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1822083568 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -37,12 +38,19 @@ public class RESTCatalogServer { private static final Logg

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1821584310 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +65,9 @@ public Map configuration() { private CatalogContext i

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1821577479 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +72,8 @@ public Map configuration() { private CatalogContext i

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1821577268 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +70,45 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

danielcweeks commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1815793488 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +70,45 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1814315018 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +72,8 @@ public Map configuration() { private CatalogContext initial

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1813548551 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +72,8 @@ public Map configuration() { private CatalogContext i

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1811968596 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +72,8 @@ public Map configuration() { private CatalogContext initial

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1811965819 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +72,9 @@ public Map configuration() { private CatalogContext initial

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1811964069 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +65,9 @@ public Map configuration() { private CatalogContext initial

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1800188393 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -89,13 +138,37 @@ public static void dropWarehouse() throws IOExceptio

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1800167581 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +70,47 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1800101451 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +65,9 @@ public Map configuration() { private CatalogContext i

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1799089974 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +70,47 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1799088453 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -89,13 +138,37 @@ public static void dropWarehouse() throws IOException {

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797441874 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +70,47 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797440932 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797440072 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797439934 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797439776 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -740,6 +743,10 @@ private boolean partitionMatch(

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797439642 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAlterTable.java: ## @@ -275,6 +278,9 @@ public void testAlterColumnPositionFirst() { @Tes

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797439446 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -18,8 +18,11 @@ */ package org.apache.iceberg.

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797438018 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAlterTable.java: ## @@ -275,6 +278,11 @@ public void testAlterColumnPositionFirst() { @Te

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797438855 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +70,47 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797263955 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797427317 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -105,6 +166,10 @@ public void before() { spark.conf().set("spar

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797318587 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,47 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797263955 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1797262749 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -89,13 +138,37 @@ public static void dropWarehouse() throws IOExceptio

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796545689 ## open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java: ## @@ -64,7 +65,9 @@ public Map configuration() { private CatalogContext initial

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796544204 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -89,13 +138,37 @@ public static void dropWarehouse() throws IOException {

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796534509 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796534994 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796534509 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796527938 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796527051 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,55 @@ protected static Object[][] parameters() { } @Befor

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796516710 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -740,6 +743,10 @@ private boolean partitionMatch(Record

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796516348 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestAlterTable.java: ## @@ -275,6 +278,9 @@ public void testAlterColumnPositionFirst() { @TestTempl

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

nastra commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796507653 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -18,8 +18,11 @@ */ package org.apache.iceberg.spark.

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796004376 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -91,10 +132,30 @@ public static void dropWarehouse() throws IOExceptio

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1795896887 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,47 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1795891887 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -59,18 +71,47 @@ protected static Object[][] parameters() { }

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1795890640 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -740,6 +743,11 @@ private boolean partitionMatch(

Re: [PR] Add REST Catalog tests to Spark 3.5 integration test [iceberg]

haizhou-zhao commented on code in PR #11093: URL: https://github.com/apache/iceberg/pull/11093#discussion_r1795881502 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java: ## @@ -521,7 +524,7 @@ public void testFilesTableTimeTr