nastra commented on code in PR #11093:
URL: https://github.com/apache/iceberg/pull/11093#discussion_r1811968596
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -64,7 +72,8 @@ public Map<String, String> configuration() {
private CatalogContext initializeBackendCatalog() throws IOException {
// Translate environment variables to catalog properties
- Map<String, String> catalogProperties =
RCKUtils.environmentCatalogConfig();
+ Map<String, String> catalogProperties = Maps.newHashMap(config);
+ catalogProperties.putAll(RCKUtils.environmentCatalogConfig());
Review Comment:
I think we might want to turn the maps around, so that the initial map comes
from `RCKUtils.environmentCatalogConfig()` and then we'd do
`catalogProperties.putAll(config)`. That way we can override stuff via `config`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
