Re: [PR] Add Files metadata table [iceberg-python]

DieHertz commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2375318027 Will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add Files metadata table [iceberg-python]

kevinjqliu commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2375285704 I think there's definitely room for improvement. @DieHertz do you mind opening an issue for this? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add Files metadata table [iceberg-python]

DieHertz commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2375186118 Hi guys, sorry if it's not the right place to ask this question. Do you know of a viable way to speed up `table.inspect.files()` for large tables? Maybe something in mind that

Re: [PR] Add Files metadata table [iceberg-python]

HonahX merged PR #614: URL: https://github.com/apache/iceberg-python/pull/614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Add Files metadata table [iceberg-python]

HonahX commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2208118906 LGTM too. @Gowthami03B Thanks for working on this! Thanks everyone for reviewing. Let's get this last metadata table in! -- This is an automated message from the Apache Git Service.

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2194621297 @Fokko @kevinjqliu @amogh-jahagirdar Can I get a re-review here please? Want to close this asap for the release timeline :) -- This is an automated message from the Apache Git

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1657080281 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,109 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1636801371 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snaps

Re: [PR] Add Files metadata table [iceberg-python]

amogh-jahagirdar commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1619789557 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self,

Re: [PR] Add Files metadata table [iceberg-python]

Fokko commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2137130504 Sorry for now following up on this @Gowthami03B Could you rebase so we can get this in? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1611151435 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1611151435 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1611039641 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1611039641 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1610653224 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snaps

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1610651660 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snaps

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1610651660 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snaps

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1606127794 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1606127794 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1606127345 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,106 @@ def update_partitions_map( schema=table_schema, ) +def files(self, snapshot_id

Re: [PR] Add Files metadata table [iceberg-python]

syun64 commented on PR #614: URL: https://github.com/apache/iceberg-python/pull/614#issuecomment-2096517390 Hi @HonahX could we get your help in triggering this workflow to see if the CI succeeds? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1585476589 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,107 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1583803213 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,107 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non df =

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1573767911 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1583228304 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1583225201 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,65 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non

Re: [PR] Add Files metadata table [iceberg-python]

kevinjqliu commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1581548947 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1581522746 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1573767911 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1573765866 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1573309559 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571245762 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,65 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non df = t

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571245762 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,65 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non df = t

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571245762 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,65 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non df = t

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571245762 ## tests/integration/test_inspect_table.py: ## @@ -445,3 +445,65 @@ def check_pyiceberg_df_equals_spark_df(df: pa.Table, spark_df: DataFrame) -> Non df = t

Re: [PR] Add Files metadata table [iceberg-python]

Fokko commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571241435 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/") .

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571237708 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa.Table

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571235918 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa.Table

Re: [PR] Add Files metadata table [iceberg-python]

geruh commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571235918 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa.Table

Re: [PR] Add Files metadata table [iceberg-python]

kevinjqliu commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571070645 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

Gowthami03B commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571063843 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

kevinjqliu commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1571023200 ## tests/conftest.py: ## @@ -2060,7 +2060,7 @@ def spark() -> "SparkSession": .config("spark.sql.catalog.hive.warehouse", "s3://warehouse/hive/")

Re: [PR] Add Files metadata table [iceberg-python]

syun64 commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1570839749 ## pyiceberg/table/__init__.py: ## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) +def files(self) -> "pa.Tabl