syun64 commented on code in PR #614: URL: https://github.com/apache/iceberg-python/pull/614#discussion_r1570839749
########## pyiceberg/table/__init__.py: ########## @@ -3537,6 +3537,58 @@ def update_partitions_map( schema=table_schema, ) + def files(self) -> "pa.Table": Review Comment: Could we add the snapshot_id as an optional argument to support time travel? Here's an example of how we are doing it for the [Partitions metadata table](https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/__init__.py#L3452) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org