Re: [PR] Add Avro compression [iceberg-python]

2025-05-08 Thread via GitHub
Fokko commented on code in PR #1976: URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2079390389 ## pyiceberg/avro/codecs/__init__.py: ## @@ -26,15 +26,21 @@ from __future__ import annotations -from typing import Dict, Optional, Type +from typing import D

Re: [PR] Add Avro compression [iceberg-python]

2025-05-08 Thread via GitHub
Fokko commented on code in PR #1976: URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2079377868 ## pyiceberg/avro/codecs/__init__.py: ## @@ -26,15 +26,21 @@ from __future__ import annotations -from typing import Dict, Optional, Type +from typing import D

Re: [PR] Add Avro compression [iceberg-python]

2025-05-07 Thread via GitHub
ndrluis commented on code in PR #1976: URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2078132016 ## pyiceberg/avro/codecs/__init__.py: ## @@ -26,15 +26,21 @@ from __future__ import annotations -from typing import Dict, Optional, Type +from typing import

[PR] Add Avro compression [iceberg-python]

2025-05-06 Thread via GitHub
Fokko opened a new pull request, #1976: URL: https://github.com/apache/iceberg-python/pull/1976 # Rationale for this change PyIceberg did not compress the Avro. This will make gzip/deflate the same as in Java. # Are these changes tested? Existing round-trip tests with Fa