Fokko merged PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
Fokko commented on PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#issuecomment-2970519232
Moving this forward, thanks @ndrluis and @sungwy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Fokko commented on code in PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2122038913
##
pyiceberg/table/update/snapshot.py:
##
@@ -126,6 +128,11 @@ def __init__(
self._deleted_data_files = set()
self.snapshot_properties = snapshot
sungwy commented on code in PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2103706160
##
pyiceberg/table/update/snapshot.py:
##
@@ -126,6 +128,11 @@ def __init__(
self._deleted_data_files = set()
self.snapshot_properties = snapsho
Fokko commented on code in PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2079390389
##
pyiceberg/avro/codecs/__init__.py:
##
@@ -26,15 +26,21 @@
from __future__ import annotations
-from typing import Dict, Optional, Type
+from typing import D
Fokko commented on code in PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2079377868
##
pyiceberg/avro/codecs/__init__.py:
##
@@ -26,15 +26,21 @@
from __future__ import annotations
-from typing import Dict, Optional, Type
+from typing import D
ndrluis commented on code in PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2078132016
##
pyiceberg/avro/codecs/__init__.py:
##
@@ -26,15 +26,21 @@
from __future__ import annotations
-from typing import Dict, Optional, Type
+from typing import
Fokko opened a new pull request, #1976:
URL: https://github.com/apache/iceberg-python/pull/1976
# Rationale for this change
PyIceberg did not compress the Avro. This will make gzip/deflate the same as
in Java.
# Are these changes tested?
Existing round-trip tests with Fa
