Fokko commented on code in PR #1976:
URL: https://github.com/apache/iceberg-python/pull/1976#discussion_r2122038913
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -126,6 +128,11 @@ def __init__(
self._deleted_data_files = set()
self.snapshot_properties = snapshot_properties
self._manifest_num_counter = itertools.count(0)
+ from pyiceberg.table import TableProperties
+
+ self._compression = self._transaction.table_metadata.properties.get(
# type: ignore
+ TableProperties.WRITE_AVRO_COMPRESSION,
TableProperties.WRITE_AVRO_COMPRESSION_DEFAULT
+ )
Review Comment:
That's a good point @sungwy, and indeed that caught us in the past. I've
added the test that you suggested, let me know what you think 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
