szehon-ho commented on PR #10472:
URL: https://github.com/apache/iceberg/pull/10472#issuecomment-2159421290
No problem, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
findepi closed pull request #10472: Add .java-version
URL: https://github.com/apache/iceberg/pull/10472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
findepi commented on PR #10472:
URL: https://github.com/apache/iceberg/pull/10472#issuecomment-2159226722
I totally forgot about https://github.com/apache/iceberg/pull/8300. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
szehon-ho commented on PR #10472:
URL: https://github.com/apache/iceberg/pull/10472#issuecomment-2158956729
Related discussion at : https://github.com/apache/iceberg/pull/8300
As a jenv user, I am not in favor of this. There is no right version here
(depends on what engines you are
findepi commented on code in PR #10472:
URL: https://github.com/apache/iceberg/pull/10472#discussion_r1633221023
##
.java-version:
##
@@ -0,0 +1 @@
+17
Review Comment:
thanks @pvary for your comment!
this matters only for people who use specific tooling to select java
pvary commented on code in PR #10472:
URL: https://github.com/apache/iceberg/pull/10472#discussion_r1633191092
##
.java-version:
##
@@ -0,0 +1 @@
+17
Review Comment:
Isn't it better to use the lowest supported version, so the issues are shown
immediately?
What if someone