findepi commented on code in PR #10472: URL: https://github.com/apache/iceberg/pull/10472#discussion_r1633221023
########## .java-version: ########## @@ -0,0 +1 @@ +17 Review Comment: thanks @pvary for your comment! this matters only for people who use specific tooling to select java version for given project. `jenv` definitely reads those files but maybe others tools do too (would be reasonable). So yes, if you have eg 8 installed and default, but 17 not installed, and you use jenv, then things won't work anymore, until you install 17. If we put 8 here, and you have 17 installed and default but 8 not installed, , and you use jenv, then things won't work anymore, until you install 8. While i agree that in general the lowest supported is the best, i would be weary putting 8 here, since it feels ancient and less likely to be already installed when someone checks the project out. This is for engineers convenience, so out could argue that newest stable & supported is the right choice for this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
