Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#issuecomment-2059024512 Close by #334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 closed pull request #320: Add `BoundPredicateVisitor` trait URL: https://github.com/apache/iceberg-rust/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1567303582 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

Fokko commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1567138774 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1566902353 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1566871505 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1566618135 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1566362815 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1566349390 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1566333861 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1565780931 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

Fokko commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1565645549 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,317 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#issuecomment-2041400457 I've added a test for `visit_op`, as well as some doc comments. Also, based on our discussion in the comments, it seemed prudent to add the `non_exhaustive` marker to `PredicateOpera

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

marvinlanhenke commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554857281 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554847639 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

marvinlanhenke commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554654358 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

marvinlanhenke commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554653083 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554546747 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554519498 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554519334 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554441701 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1554438555 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

marvinlanhenke commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553740208 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553653540 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

marvinlanhenke commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553297280 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

marvinlanhenke commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553297280 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553279624 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553253806 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553220669 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553215173 ## crates/iceberg/src/expr/predicate.rs: ## @@ -217,6 +249,10 @@ impl Display for SetExpression { /// Unbound predicate expression before binding to a schema.

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553098425 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,363 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553082179 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,363 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

sdd commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553077742 ## crates/iceberg/src/expr/predicate.rs: ## @@ -217,6 +249,10 @@ impl Display for SetExpression { /// Unbound predicate expression before binding to a schema. #[derive

Re: [PR] Add `BoundPredicateVisitor` trait [iceberg-rust]

liurenjie1024 commented on code in PR #320: URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1552969104 ## crates/iceberg/src/expr/visitors/bound_predicate_visitor.rs: ## @@ -0,0 +1,363 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more