sdd commented on code in PR #320:
URL: https://github.com/apache/iceberg-rust/pull/320#discussion_r1553077742
##########
crates/iceberg/src/expr/predicate.rs:
##########
@@ -217,6 +249,10 @@ impl<T: Display + Debug> Display for SetExpression<T> {
/// Unbound predicate expression before binding to a schema.
#[derive(Debug, PartialEq)]
pub enum Predicate {
+ /// AlwaysTrue predicate, for example, `TRUE`.
+ AlwaysTrue,
+ /// AlwaysFalse predicate, for example, `FALSE`.
+ AlwaysFalse,
Review Comment:
It's in here because it is needed in two places in `InclusiveProjection`:
- First, when we "unbind", transforming a `BoundPredicate` into an unbound
`Predicate`:
https://github.com/apache/iceberg-rust/pull/321/files#diff-419289c8023c272de50ee4352320ad217fa7c2802f7f633d26e55ece30426be6R41
- Second, when we build up a `Predicate` by "and"ing together a (possibly
empty) list of `Predicate`s, starting with an `AlwaysTrue` to ensure that we
return a valid `Predicate` even in the empty list case:
https://github.com/apache/iceberg-rust/pull/321/files#diff-419289c8023c272de50ee4352320ad217fa7c2802f7f633d26e55ece30426be6R76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
