[PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-05-30 Thread via GitHub
xiaoxuandev opened a new pull request, #12695: URL: https://github.com/apache/iceberg/pull/12695 This change adds support for `StaticCredentialsProvider` in `DefaultAwsClientFactory`. Fixes #10614. Using the following properties to use `StaticCredentialsProvider`: ``` AwsClient

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-05-30 Thread via GitHub
yyanyy commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2923579883 reopening since the issue is still relevant; I do agree that this feature is not a best practice in production, but looks like there are two valid use cases for development: - integra

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-05-30 Thread via GitHub
yyanyy commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2923580299 reopening since the issue is still relevant; I do agree that this feature is not a best practice in production, but looks like there are two valid use cases for development: integ

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-05-09 Thread via GitHub
github-actions[bot] commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2868134939 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-05-09 Thread via GitHub
github-actions[bot] closed pull request #12695: AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory URL: https://github.com/apache/iceberg/pull/12695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2848305938 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-04-05 Thread via GitHub
morozov commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2773821450 > @morozov did you try using the environment variables in the k8s pod config or mounting a credentials file to configure these values? Mounting credentials wasn't an option. The a

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-04-05 Thread via GitHub
danielcweeks commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2766554527 @xiaoxuandev Do you have a specific use case for this? In general, I think this is bad practice since you ideally wouldn't be configuring credentials explicitly. Is there a reaso

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-04-04 Thread via GitHub
morozov commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2773810216 > @xiaoxuandev Do you have a specific use case for this? In general, I think this is bad practice since you ideally wouldn't be configuring credentials explicitly. Is there a reason the

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-04-02 Thread via GitHub
xiaoxuandev commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2773788746 @danielcweeks, I think it's a valid use case, not just for user, even for CI pipeline, currently AWS integration tests are not running in pipeline, but we are spend effort to have i

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-04-02 Thread via GitHub
danielcweeks commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2773642909 > Thanks @danielcweeks, while environment variables work in Kubernetes, they aren’t always the best solution for all deployment scenarios . . . @xiaoxuandev it feels like we'

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-03-31 Thread via GitHub
xiaoxuandev commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2767045401 > @xiaoxuandev The [default credential provider chain](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/credentials-chain.html) supports setting these values via envi

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-03-31 Thread via GitHub
danielcweeks commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2766961012 @xiaoxuandev The d[efault credential provider chain](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/credentials-chain.html) supports setting these values via envir

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-03-31 Thread via GitHub
xiaoxuandev commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-2766587227 > @xiaoxuandev Do you have a specific use case for this? In general, I think this is bad practice since you ideally wouldn't be configuring credentials explicitly. Is there a reason

[PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-03-30 Thread via GitHub
xiaoxuandev opened a new pull request, #12695: URL: https://github.com/apache/iceberg/pull/12695 This change adds support for `StaticCredentialsProvider` in `DefaultAwsClientFactory`. Using the following properties to use `StaticCredentialsProvider`: ``` AwsClientProperties.CLI