danielcweeks commented on PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#issuecomment-2379484397
@ookumuso After thinking about this a little more, I'm increasingly
concerned about the high value for defaults. If we look at this in isolation,
it seems like the right thing to
amogh-jahagirdar commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777830154
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
danielcweeks commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r153530
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
danielcweeks commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777363011
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
ookumuso commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777652003
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
p
drewschleit commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777470471
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
}
drewschleit commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777451480
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
}
drewschleit commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777451480
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
}
danielcweeks commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777369877
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
danielcweeks commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777369877
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -824,6 +889,65 @@ public void
applyEndpointConfigurations(T builder) {
}
amogh-jahagirdar commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777340404
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
amogh-jahagirdar commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1777340404
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
jackye1995 commented on PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#issuecomment-2374896767
@ookumuso looks like CI failed for some unrelated reason, can you rebase the
PR to retrigger the CI?
--
This is an automated message from the Apache Git Service.
To respond to the
jackye1995 commented on PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#issuecomment-2374873258
@amogh-jahagirdar @nastra for the concerns regarding the new config values,
to give some additional data points here, we have similar configs internally
for quite some time now in Ic
ookumuso commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1773679309
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
p
ookumuso commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1764233622
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
p
ookumuso commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1764233622
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
p
amogh-jahagirdar commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1764104918
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
ookumuso commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1763561503
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
p
nastra commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1762443878
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##
@@ -393,6 +403,21 @@ public class S3FileIOProperties implements Serializable {
*/
pri
ookumuso commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1761455914
##
docs/docs/aws.md:
##
@@ -378,6 +378,19 @@ However, for the older versions up to 0.12.0, the logic is
as follows:
For more details, please refer to the [Locati
nastra commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1760984150
##
docs/docs/aws.md:
##
@@ -378,6 +378,19 @@ However, for the older versions up to 0.12.0, the logic is
as follows:
For more details, please refer to the [Location
22 matches
Mail list logo
