Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-25 Thread via GitHub
aajisaka commented on PR #10972: URL: https://github.com/apache/iceberg/pull/10972#issuecomment-2309302503 Thank you @singhpk234 @nastra and @amogh-jahagirdar ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-24 Thread via GitHub
amogh-jahagirdar merged PR #10972: URL: https://github.com/apache/iceberg/pull/10972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-23 Thread via GitHub
aajisaka commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1728922027 ## aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java: ## @@ -202,6 +206,23 @@ public void testNewInputStreamWithCrossRegionAccessPoint(

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-23 Thread via GitHub
aajisaka commented on PR #10972: URL: https://github.com/apache/iceberg/pull/10972#issuecomment-2306974223 Ran the new integration tests without adding the dependency: testNewInputStreamWithMultiRegionAccessPoint() ``` software.amazon.awssdk.core.exception.SdkException: Failed to

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-23 Thread via GitHub
aajisaka commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1728875949 ## aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java: ## @@ -202,6 +206,23 @@ public void testNewInputStreamWithCrossRegionAccessPoint(

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-23 Thread via GitHub
nastra commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1728580343 ## aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java: ## @@ -202,6 +206,23 @@ public void testNewInputStreamWithCrossRegionAccessPoint()

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-22 Thread via GitHub
aajisaka commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1727273820 ## aws-bundle/build.gradle: ## @@ -27,6 +27,7 @@ project(":iceberg-aws-bundle") { implementation platform(libs.awssdk.bom) implementation "software.amazon.

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1727014510 ## aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java: ## @@ -202,6 +206,23 @@ public void testNewInputStreamWithCrossRegionAccessPoint()

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1727002025 ## aws-bundle/build.gradle: ## @@ -27,6 +27,7 @@ project(":iceberg-aws-bundle") { implementation platform(libs.awssdk.bom) implementation "software.amazon.aw

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10972: URL: https://github.com/apache/iceberg/pull/10972#discussion_r1726996810 ## aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java: ## @@ -251,6 +272,24 @@ public void testNewOutputStreamWithCrossRegionAccessPoint(

Re: [PR] AWS: Include http-auth-aws-crt module into iceberg-aws-bundle [iceberg]

2024-08-21 Thread via GitHub
aajisaka commented on PR #10972: URL: https://github.com/apache/iceberg/pull/10972#issuecomment-2302093343 Thank you @singhpk234. There're existing tests for cross-region access point, but there's no test for multi-region access point. Added integration tests for multi-region access point a