nastra commented on code in PR #10972:
URL: https://github.com/apache/iceberg/pull/10972#discussion_r1726996810
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -251,6 +272,24 @@ public void
testNewOutputStreamWithCrossRegionAccessPoint() throws Exception {
assertThat(result).isEqualTo(content);
}
+ @Test
+ public void testNewOutputStreamWithMultiRegionAccessPoint() throws Exception
{
+ Assumptions.assumeThat(multiRegionAccessPointAlias).isNotEmpty();
+
clientFactory.initialize(ImmutableMap.of(S3FileIOProperties.USE_ARN_REGION_ENABLED,
"true"));
+ S3FileIO s3FileIO = new S3FileIO(clientFactory::s3);
+ s3FileIO.initialize(
+ ImmutableMap.of(
+ S3FileIOProperties.ACCESS_POINTS_PREFIX + bucketName,
+ testMultiRegionAccessPointARN(
+ AwsIntegTestUtil.testRegion(), multiRegionAccessPointAlias)));
+ write(s3FileIO);
+ InputStream stream =
Review Comment:
maybe run this with a try-with-resources block so that you don't need the
explicit `close()` call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
