amogh-jahagirdar commented on PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#issuecomment-2599281346
I'm going to go ahead and merge this, it's been ready for a while and didn't
want to miss this change going in for the next release! Thank you @wzx140 and
thank you @singhpk234
amogh-jahagirdar merged PR #11764:
URL: https://github.com/apache/iceberg/pull/11764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on code in PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#discussion_r1887086788
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -723,6 +723,9 @@ public int hashCode() {
public static class StructType extends NestedTy
amogh-jahagirdar commented on code in PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#discussion_r1887057599
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -824,7 +827,10 @@ public boolean equals(Object o) {
@Override
public int hashCode
wzx140 commented on code in PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#discussion_r1885468839
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -824,7 +827,10 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
-
singhpk234 commented on PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#issuecomment-2542605844
> Pre-execution Preparation Time: the time interval from the first table
load to the start of the first stage execution
Scan Spec Time: added a timer to the method SparkPartitionin
singhpk234 commented on code in PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#discussion_r1884691655
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -824,7 +827,10 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
-
wzx140 commented on PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#issuecomment-2540416245
> Q: does it completely mitigate the flatness observed ? can you please
attach the flame graph now ? Interesting find @wzx140
**Performance Comparison After Adding Cache**
|
singhpk234 commented on PR #11764:
URL: https://github.com/apache/iceberg/pull/11764#issuecomment-2539708719
Q: does it completely mitigate the flatness observed ? can you please attach
the flame graph now ?
Interesting find @wzx140
--
This is an automated message from the Apache Git
